Skip to content

Convert command's timeout for incremental snapshots #13212

Open
erikbocks wants to merge 1 commit into
apache:4.22from
scclouds:fix-incremental-snapshot-timeout
Open

Convert command's timeout for incremental snapshots #13212
erikbocks wants to merge 1 commit into
apache:4.22from
scclouds:fix-incremental-snapshot-timeout

Conversation

@erikbocks
Copy link
Copy Markdown
Collaborator

@erikbocks erikbocks commented May 21, 2026

Description

This PR handles the conversion of command's timeout for incremental snapshots, complementing the #13210 changes (reason: #13210 (comment)).

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@erikbocks erikbocks requested a review from winterhazel May 21, 2026 19:47
winterhazel
winterhazel approved these changes May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@winterhazel winterhazel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but did not test.

@winterhazel
Copy link
Copy Markdown
Member

winterhazel commented May 21, 2026

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 21, 2026

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.67%. Comparing base (d1e1aa5) to head (c98b124).
⚠️ Report is 6 commits behind head on 4.22.

Files with missing lines Patch % Lines
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.22   #13212      +/-   ##
============================================
- Coverage     17.67%   17.67%   -0.01%     
- Complexity    15791    15792       +1     
============================================
  Files          5922     5922              
  Lines        533127   533128       +1     
  Branches      65205    65205              
============================================
  Hits          94243    94243              
  Misses       428239   428239              
- Partials      10645    10646       +1
Flag Coverage Δ
uitests 3.69% <ø> (ø)
unittests 18.75% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 21, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17971

DaanHoogland
DaanHoogland reviewed May 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm generally, just wondering if we could hit an overflow

Comment thread plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
}

private void retryRebase(String snapshotName, int wait, Exception e, QemuImgFile snapshotFile, QemuImgFile parentSnapshotFile) {
private void retryRebase(String snapshotName, int waitInMilliseconds, Exception e, QemuImgFile snapshotFile, QemuImgFile parentSnapshotFile) {
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this always fit in an int?

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented May 22, 2026

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 22, 2026

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@DaanHoogland DaanHoogland mentioned this pull request May 22, 2026
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland left review comments

@winterhazel winterhazel winterhazel approved these changes

Assignees

No one assigned

Labels

component:kvm status:needs-review status:needs-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erikbocks @winterhazel @blueorangutan @DaanHoogland